[wp-trac] [WordPress Trac] #59505: Fix HTML5 validation error for skip-link css on footer

WordPress Trac noreply at wordpress.org
Thu Oct 12 05:24:14 UTC 2023


#59505: Fix HTML5 validation error for skip-link css on footer
---------------------------------------+------------------------------
 Reporter:  plugindevs                 |       Owner:  < plugindevs >
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  Awaiting Review
Component:  Themes                     |     Version:  5.9
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  css
---------------------------------------+------------------------------
Changes (by sabernhardt):

 * version:  trunk => 5.9
 * severity:  critical => normal


Comment:

 Hi and thanks for the report!

 If the function name should change, the old function would need to be
 moved to `deprecated.php`.

 However, I think moving the CSS //might// be simpler now that the
 [https://core.trac.wordpress.org/changeset/56687/trunk/src/wp-includes
 /theme-templates.php script is registered and enqueued] instead of
 printing it all directly into the footer.

 If my proof-of-concept patch is good, it probably should also have some
 documentation updates and
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/admin-
 bar.php?rev=56682#L1262 backward compatibility code] for anyone who
 removed `the_block_template_skip_link` from the `wp_footer` action. That
 includes the [https://wpdirectory.net/search/01HBHGGPVQD155EF6H3C05SBB1
 AMP plugin], [https://wpdirectory.net/search/01HBHGN79189AE72JZZVZ6QE7W
 WeCodeArt and emulsion themes], plus some others in a
 [https://github.com/search?q=%27the_block_template_skip_link%27&type=code
 GitHub code search].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59505#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list