[wp-trac] [WordPress Trac] #59360: update_network_option() strict checks can cause false negatives

[WordPress Trac]

#59360: update_network_option() strict checks can cause false negatives
-------------------------------------------------+-------------------------
 Reporter:  mukesh27                             |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.4
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests has-patch commit      |     Focuses:
  dev-feedback                                   |  performance
-------------------------------------------------+-------------------------

Comment (by joemcgill):

 Replying to [comment:30 costdev]:
 > ...I'm thinking we should revert for 6.4 and reconsider our strategy
 here.
 >
 > This component is so crucial for plugins, and despite having a possible
 fix for the latest issue, we've now identified a few breaks during this
 work and it's getting late in the cycle. I'm not yet confident that we
 have a stable enough patch for release.

 Thanks for raising the question, @costdev. I'd like to see if we can
 remove the `pre_filter` juggling in both functions and add tests that
 validate that the previous behavior is protected when `pre_filters` are in
 place. However, if we can't get a good solution before RC1, I do think
 your proposal makes sense.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59360#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform