[wp-trac] [WordPress Trac] #59360: update_network_option() strict checks can cause false negatives
WordPress Trac
noreply at wordpress.org
Wed Oct 11 21:23:56 UTC 2023
#59360: update_network_option() strict checks can cause false negatives
---------------------------------------------+--------------------------
Reporter: mukesh27 | Owner: flixos90
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 6.4
Component: Options, Meta APIs | Version:
Severity: normal | Resolution:
Keywords: has-unit-tests has-patch commit | Focuses: performance
---------------------------------------------+--------------------------
Comment (by costdev):
> This ticket seems pretty much a duplicate of #22192. Even the
description is copied from there.
Shouldn't the commit here be reverted and then both places be fixed from
#22192, as the method to fix these and the code is the same?
There's some different considerations between the functions, such as
different filters/numbers of filters, nullable vs non-nullable database
fields and such. IMO, it's been beneficial having the work for each
function separated to allow us to focus on a given function in its own
context.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59360#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list