[wp-trac] [WordPress Trac] #57035: Error in current_time() function when using timestamp and no value for gmt_offset

[WordPress Trac]

#57035: Error in current_time() function when using timestamp and no value for
gmt_offset
-------------------------------------------------+-------------------------
 Reporter:  Nick_theGeek                         |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.5
Component:  Date/Time                            |     Version:  5.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  testing php80 dev-feedback                     |
-------------------------------------------------+-------------------------
Changes (by nicolefurlan):

 * keywords:  has-patch has-unit-tests needs-testing php80 => has-patch has-
     unit-tests needs-testing php80 dev-feedback
 * milestone:  6.4 => 6.5


Comment:

 This ticket was discussed in today's bug scrub.

 We decided to move this (and #58986) to 6.5. Per @hellofromTonya:
 > I'm concerned about both of these tickets going in this late in the
 release due to the lack of test coverage and testing. Why? Casting with
 `inval()` for the one and `(float)` for the other may have side effects.
 Thinking it needs a contextual dive into how the code got to the current
 state to avoid potentially introducing a regression.

 @SergeyBiryukov or @rarst if you have time to review and have confidence
 in this fix, don't hesitate to pull it back into the 6.4 milestone.

 Props to @hellofromTonya :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57035#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform