[wp-trac] [WordPress Trac] #58132: Slashes used in block templates slug is a problem on Windows
WordPress Trac
noreply at wordpress.org
Wed Oct 11 18:41:05 UTC 2023
#58132: Slashes used in block templates slug is a problem on Windows
-------------------------------------------------+-------------------------
Reporter: gaft | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.5
Component: Editor | Version: 5.9
Severity: normal | Resolution:
Keywords: reporter-feedback has-patch has- | Focuses:
unit-tests 2nd-opinion has-testing-info |
needs-testing |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):
* milestone: 6.4 => 6.5
Comment:
This ticket was discussed today in pre-RC1 bug scrub.
In reviewing, I had some thoughts and questions.
* On the proposed patch / PR:
Rather than normalizing after the skip checks, likely need to normalize
the slug for both of the skip checks, i.e. normalize just after the
`$template_slug` is built.
* What is the impact elsewhere?
How will normalizing in this function impact where the template slug is
used elsewhere? Are there impacts or side effects elsewhere?
* Next steps towards resolution.
Maybe moving it to Gutenberg could help move it forward? Or folks working
on the templates could take a look here to share insights to the above
questions.
Given the questions combined with 6.4 RC1 happening in 6 days, I don't
think there's enough time left in the 6.4 cycle.
If the questions get answered and there's confidence from maintainers /
leads / committers the fix will not cause impacts elsewhere, then please
move it back into the milestone for consideration.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/58132#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list