[wp-trac] [WordPress Trac] #59584: Deactivate older versions of Gutenberg plugin when upgrading to WP 6.4

[WordPress Trac]

#59584: Deactivate older versions of Gutenberg plugin when upgrading to WP 6.4
-------------------------------------------------+-------------------------
 Reporter:  hellofromTonya                       |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.4
Component:  Upgrade/Install                      |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing has-patch has-         |     Focuses:
  testing-info                                   |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  needs-testing has-patch => needs-testing has-patch has-
     testing-info


Comment:

 == Test Report

 Scenario:
 Test what happens when upgrading from WP 6.3.1 to WP 6.4 Beta 2 when an
 incompatible (16.4) or compatible (16.5) version of the Gutenberg plugin
 is activated.

 Env:
 * Localhost: Local
 * WordPress: 6.3.1 and 6.4 Beta 2
 * OS: macOS
 * Webserver: nginx
 * Theme: default theme
 * Plugins:
   * Gutenberg versions 16.4 and 16.5
   * Beta Tester

 === Test Instructions

 1. Install WordPress 6.3.1.
 2. Download Gutenberg 16.4 from the wp . org plugin Advanced View UI:
    * Go to the plugin's [https://wordpress.org/plugins/gutenberg/advanced/
 Advanced View page].
    * Select the version to download in the Previous Versions section.
    * Select the "Download" button.
 3. Add the plugin's zip file by:
   * Go into your test site's admin area and navigate to Plugins > Add New
 > Upload Plugin.
   * Choose or drop and drag the zip file to the "Choose File" field.
   * Select the "Install Now" button.
 4. Then activate the plugin.
 5. Upgrade from WordPress 6.3.1 to 6.4 Beta 2.
 [https://wordpress.org/news/2023/10/wordpress-6-4-beta-2/ Instructions on
 how to upgrade are found in the announcement post] (i.e. using wp-cli,
 Beta Tester plugin, etc.).
 6. After WordPress upgrades, notice the result.

 === Expected Results

 When reproducing a bug:

 * An incompatible version such as GB 16.4 will cause a fatal error after
 WordPress upgrade to 6.4 Beta 1+ happens 🐞 ❌

 * A compatible version such as GB 16.5 will complete the upgrade process
 without an error ✅.

 When testing the patch resolves the issue:
 * Plugin versions less than 16.5 are deactivated without an error ✅.

 === Reproduce Issue Test Results

 ==== Using Gutenberg 16.5

 No fatal errors occurred.

 The upgrade from 6.3.1 to 6.4 Beta 2 was successful.

 ==== Using Gutenberg 16.4

 A fatal error is thrown during the upgrade process:

 >Fatal error: Access level to
 Gutenberg_REST_Global_Styles_Controller_6_2::validate_custom_css() must be
 protected (as in class WP_REST_Global_Styles_Controller) or weaker in
 /../public/wp-content/plugins/gutenberg/lib/compat/wordpress-6.2/class-
 gutenberg-rest-global-styles-controller-6-2.php on line 217
 >
 >There has been a critical error on this website. Please check your site
 admin email inbox for instructions.
 >
 >Learn more about troubleshooting WordPress.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59584#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform