[wp-trac] [WordPress Trac] #56922: Template / Template parts revision / autosave REST API are broken
WordPress Trac
noreply at wordpress.org
Tue Oct 10 13:37:50 UTC 2023
#56922: Template / Template parts revision / autosave REST API are broken
--------------------------------------+-----------------------
Reporter: spacedmonkey | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.4
Component: REST API | Version: 4.7
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses: rest-api
--------------------------------------+-----------------------
Changes (by hellofromTonya):
* keywords: has-patch has-unit-tests needs-testing changes-requested =>
has-patch has-unit-tests
Comment:
Bringing
[https://wordpress.slack.com/archives/C02RQBWTW/p1696944794209679?thread_ts=1696925510.206899&cid=C02RQBWTW
my comments over from Make/Core slack]:
>What about committing it?
>
>I have concerns of committing a patch with this amount of changes,
especially one that introduces new public properties and methods. This is
why I asked for additional test reports.
>
>The test reports revealed some observations, some of which will require
follow-up in new tickets (some revealed issues upstream as Jonny noted).
>
>The PR has gone through a thorough review with approvals from a REST API
Maintainer @kadamwhite and Committers including @kadamwhite and @costdev.
There are multiple test reports showing it works as expected including the
ones from yesterday from @antonvlasenko and @ironprogrammer.
>
>IMO a big change like this being committed in the last beta release is
concerning, but the risk concerns are mitigated enough by all of the
above. And they can be further validated in Beta 3 and even into RC,
should a follow-up or revert be required.
>
>I think it's a green light :large_green_circle: to proceed with the
commit.
Leaving the `commit` decision to those who are deeply involved in its
development and approval process.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56922#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list