[wp-trac] [WordPress Trac] #55491: Replace `unload` event handlers from core

WordPress Trac noreply at wordpress.org
Mon Oct 9 21:29:57 UTC 2023


#55491: Replace `unload` event handlers from core
----------------------------+--------------------------------------
 Reporter:  shawfactor      |       Owner:  westonruter
     Type:  defect (bug)    |      Status:  closed
 Priority:  normal          |   Milestone:  6.4
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:  fixed
 Keywords:  has-patch       |     Focuses:  javascript, performance
----------------------------+--------------------------------------
Changes (by westonruter):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"56809" 56809]:
 {{{
 #!CommitTicketReference repository="" revision="56809"
 Administration: Remove deprecated `unload` event handlers and use
 `pagehide` (and `pageshow`) when appropriate.

 Use `pagehide` event instead of `unload` in the following cases:

 * For classic editor to release the post lock.
 * In Text widget to rebuild editor after dragging widget to new location
 in classic widgets interface.
 * To clear out the `window.name` when navigating away from a post preview.
 * To suspend heartbeat, while also using `pageshow` event to resume as if
 it had been a focused tab in case page restored from bfcache.

 Also:

 * Remove obsolete mobile cleanup code in `js/_enqueues/lib/gallery.js`
 (introduced in [9894]). Do same for `src/js/_enqueues/wp/media/models.js`
 (introduced in [22872]). See #22552.
 * Remove obsolete Firefox-specific workaround in `js/_enqueues/wp/mce-
 view.js` from [39282]. See #38511.

 Fixes #55491.
 Props spenserhale, westonruter, adamsilverstein, azaozz, shawfactor,
 peterwilsoncc, swissspidy.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55491#comment:44>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list