[wp-trac] [WordPress Trac] #45929: Potential assignment to empty string

[WordPress Trac]

#45929: Potential assignment to empty string
-------------------------------------------------+-------------------------
 Reporter:  jugglinmike                          |       Owner:  swissspidy
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.4
Component:  Shortcodes                           |     Version:  5.0.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch changes-requested good-    |     Focuses:
  first-bug has-unit-tests close                 |
-------------------------------------------------+-------------------------

Comment (by oglekler):

 @swissspidy no, it is not a duplicate, the function in question is
 publicly accessible and this means that it can be called without
 appropriate arguments. And @brianhenryie has a point, these case can be
 covered with unit test, but the patch needs rebase, and it don't need
 `isset()`, because `$attr` is required by function and without it there
 will be a fatal error and this will be impossible to miss.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45929#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform