[wp-trac] [WordPress Trac] #59443: Block Supports: Re-use instance of Tag Processor when adding layout classes
WordPress Trac
noreply at wordpress.org
Fri Oct 6 00:02:30 UTC 2023
#59443: Block Supports: Re-use instance of Tag Processor when adding layout classes
---------------------------------------+----------------------------
Reporter: dmsnell | Owner: isabel_brison
Type: enhancement | Status: reopened
Priority: normal | Milestone: 6.4
Component: Editor | Version: trunk
Severity: normal | Resolution:
Keywords: gutenberg-merge has-patch | Focuses: performance
---------------------------------------+----------------------------
Comment (by isabel_brison):
Thanks for your detailed reply @dmsnell!
> For the big changes to this function, around which this discussion is
taking place, introduced in #57584, there's an obvious oddity in how it's
trying to find the inner block wrapper, assuming it exists.
For context, the relevant changes in Gutenberg were from this PR:
https://github.com/WordPress/gutenberg/pull/44600 (which was incidentally
the first use of the HTML tag processor, before it landed in core even).
There's a fair amount of discussion in the PR, but
https://github.com/WordPress/gutenberg/pull/44600#issuecomment-1269334562
points to why we ended up with such a roundabout solution: InnerBlocks
couldn't reliably be used for all blocks.
This is not to say we can't come up with a better solution, given time!
There are many different implementations and states of container blocks
that have to be taken into account though, so that's definitely not a task
for this release.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/59443#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list