[wp-trac] [WordPress Trac] #59464: Images in 2024 theme do not have modern image features

WordPress Trac noreply at wordpress.org
Wed Oct 4 20:14:44 UTC 2023


#59464: Images in 2024 theme do not have modern image features
--------------------------+--------------------------
 Reporter:  spacedmonkey  |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  6.4
Component:  Themes        |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  performance
--------------------------+--------------------------

Comment (by flixos90):

 @spacedmonkey The proposed fix relies only partially on TT4, it's also
 touching core. It's only a proof of concept anyway though.

 @joemcgill I agree with your concerns.

 Taking a step back here, I wonder how much value there is in addressing
 the missing `width` and `height` problem for template images in the first
 place: The issue is about default theme images - which seems significant
 to address given we commonly use the untouched default theme templates in
 our benchmarks, but is this realistically even going to be a problem? Most
 sites probably won't use the default stock images that come with a theme,
 so they will replace them with media files, and then the problem of
 missing width and height will be gone.

 I think what this indicates to me is that we may want to alter our
 benchmarking setup somehow, so that we test with sites using proper
 attachment images in the templates.

 Separately though, the PR also covers another problem related to this
 ticket, which I think is more important: Even when `width` and `height`
 attributes are present, the image optimization attributes are not applied
 correctly with TT4. See lines https://github.com/WordPress/wordpress-
 develop/pull/5324/files#diff-
 4d28b6652f0dab208c19aa45e1cf09f3c967060d8cc77502bfcd473a3216b612R5647 and
 following for the relevant proposed change (plus further detail in the 2nd
 bullet point in the PR description). I think we should refocus the effort
 of this ticket on the latter, which is a bug that even applies to
 attachment images.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59464#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list