[wp-trac] [WordPress Trac] #58407: resetpassword action on users.php (users list page) handles retrieve_password() return incorrectly

[WordPress Trac]

#58407: resetpassword action on users.php (users list page) handles
retrieve_password() return incorrectly
-------------------------------------------------+-------------------------
 Reporter:  letraceursnork                       |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.3
Component:  Users                                |     Version:  6.2.2
 Severity:  trivial                              |  Resolution:
 Keywords:  good-first-bug has-patch needs-      |     Focuses:  ui,
  refresh                                        |  administration
-------------------------------------------------+-------------------------

Comment (by petitphp):

 > I believe it should be good if we display an error notice instead of a
 success notice.
 This ticket was about fixing a condition check. I agree the notice could
 be rework to be more precise about what really happened but I think this
 should be handle in a follow-up ticket and not in this one.

 The original patch from @prashantbhivsane in comment 4 looks good to me.
 As Sergey mentioned it would be good to update all the conditions to use
 the same pattern (either `true ===` or `is_wp_error`).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58407#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform