[wp-trac] [WordPress Trac] #58400: Current version should comes from variable or constant only.

WordPress Trac noreply at wordpress.org
Thu May 25 08:55:52 UTC 2023


#58400: Current version should comes from variable or constant only.
-----------------------------------+-------------------------------
 Reporter:  umeshmcakadi           |       Owner:  (none)
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Help/About             |     Version:  6.2.2
 Severity:  normal                 |  Resolution:
 Keywords:  has-screenshots close  |     Focuses:  coding-standards
-----------------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-patch has-screenshots => has-screenshots close
 * component:  Administration => Help/About


Comment:

 Hi there, welcome back to WordPress Trac! Thanks for the ticket.

 When looking at the file as a whole, you may find that `$display_version`
 is used in strings like:
 * `Welcome to WordPress %s`
 * `Learn more about WordPress %s`

 However, maintenance and security release entries (see
 [source:tags/6.2.2/src/wp-admin/about.php?marks=83,94#L74 6.2.1 for
 example]) use a hardcoded version number. Using `$display_version` there
 does not seem to provide any benefits, and would only add more work for
 the release team, as it would no longer be accurate for the previous
 release once a new one is available, so it would have to be replaced each
 time for a new release, and might be easy to miss.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58400#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list