[wp-trac] [WordPress Trac] #40206: wp_insert_term() $slug_provided check fails

[WordPress Trac]

#40206: wp_insert_term() $slug_provided check fails
--------------------------+------------------------------
 Reporter:  esemlabel     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Taxonomy      |     Version:  4.7.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by albatross10):

 I also tested the case present in the
 https://core.trac.wordpress.org/ticket/39984

 I added $$$$ and continued to add it. And this adds the term ID as slug.
 So the check present prevents $$$$ from adding again. If we proceed with
 removing that line and do this:


 {{{
 if ( $name_match->slug === $slug || $slug_match ) {
 }}}


 It continues to add it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40206#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform