[wp-trac] [WordPress Trac] #58298: Deprecated errors on /wp-admin/revision.php?revision=2895&gutenberg=true

[WordPress Trac]

#58298: Deprecated errors on /wp-admin/revision.php?revision=2895&gutenberg=true
-----------------------------+---------------------
 Reporter:  thomask          |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  6.3
Component:  Editor           |     Version:  6.2
 Severity:  normal           |  Resolution:
 Keywords:  php82 has-patch  |     Focuses:
-----------------------------+---------------------

Comment (by SergeyBiryukov):

 Replying to [comment:2 jrf]:
 > The `Text_Diff` library is an external dependency, however, AFAIK it is
 no longer externally maintained.

 The [https://github.com/pear/Text_Diff pear/Text_Diff] project on GitHub
 had a release in 2019 and appears to have
 [https://github.com/pear/Text_Diff/commit/14a70077f643739639845cebaea36a58d647b8c7
 recent commits], though is indeed no longer actively maintained, as it has
 been deprecated and superseded by [https://github.com/horde/Text_Diff
 Horde_Text_Diff].

 We could probably consider switching to the newer package. On at least one
 occasion though, we encountered a bug in the upstream version, see
 comment:5:ticket:41526, that was patched using a different approach in
 [42028] / #41526. As far as I can tell, there were
 [https://github.com/horde/Text_Diff/commits/master/lib/Horde/Text/Diff/Engine/Native.php
 no further changes] upstream after the [comment:12:ticket:41526 commits in
 question], so the issue still exists there.

 I have not yet checked whether a [https://github.com/pear/Text_Diff/pull/7
 similar fix for pear/Text_Diff] has the same issue.

 > I wonder if it may be prudent to create a repo to maintain this code as
 a package within the WP organisation ?

 Would it be worth comparing the current code in core with the
 [https://github.com/pear/Text_Diff pear/Text_Diff] version and checking if
 a switch would be possible? Otherwise, it looks like we may indeed have to
 continue maintaining this package for the time being, either in core or
 separately, to ensure compatibility with newer PHP versions.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58298#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform