[wp-trac] [WordPress Trac] #57998: current_time function: GMT offset is not always an integer
WordPress Trac
noreply at wordpress.org
Tue Mar 28 10:45:27 UTC 2023
#57998: current_time function: GMT offset is not always an integer
------------------------------------------+-----------------------
Reporter: reputeinfosystems | Owner: (none)
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 6.2.1
Component: Date/Time | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch needs-unit-tests | Focuses:
------------------------------------------+-----------------------
Comment (by hellofromTonya):
The questions being considered are:
* How severe is this regression?
* What are its impact on users?
The answers to these questions will help to determine if this can be fixed
in 6.2.1 or if it must be fixed now before the 6.2 final release (causing
the release to be delayed until tomorrow).
Some context:
* Regression introduced by [55054] / #57035 to fix a fatal error in PHP
8+.
* [https://wpdirectory.net/search/01GWKRC1S93T39EXRZ886A7PJY 10,973+
plugins] use this function including:
* The Events Calendar
* MailPoet
* Jetpack
* WooCommerce
* A quick scan of their usages shows these impacts:
* Incorrect queries in commerce stores
* Incorrect human readable times
* Incorrect time for task triggers (such as MailPoet for cron workers)
Are there other impacts? Of those identified, how severe are they?
In discussing with @audrasjb, we're currently thinking the severity is not
severe enough to warrant delaying the 6.2 final release by a day, but
rather to do a fast 6.2.1 release.
What do you think?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57998#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list