[wp-trac] [WordPress Trac] #55132: Unused variable

WordPress Trac noreply at wordpress.org
Tue Mar 21 13:24:39 UTC 2023


#55132: Unused variable
--------------------------+-------------------------------
 Reporter:  azouamauriac  |       Owner:  SergeyBiryukov
     Type:  enhancement   |      Status:  reviewing
 Priority:  normal        |   Milestone:  6.3
Component:  Plugins       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  coding-standards
--------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => reviewing
 * milestone:  Awaiting Review => 6.3


Comment:

 Hi there, thanks for the patch!

 It looks like this exact line also exists in a few other list tables:
 {{{
 list( $columns, $hidden, $sortable, $primary ) = $this->get_column_info();
 }}}
 So I think I'd like to leave it as is for consistency, even though
 `$sortable` and `$primary` are not used here.

 The other change looks good to me.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55132#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list