[wp-trac] [WordPress Trac] #57482: Remove the Unused variables in the wp-includes folder.

WordPress Trac noreply at wordpress.org
Sat Mar 18 12:33:10 UTC 2023


#57482: Remove the Unused variables in the wp-includes folder.
--------------------------+-------------------------------
 Reporter:  upadalavipul  |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  6.3
Component:  General       |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |     Focuses:  coding-standards
--------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"55559" 55559]:
 {{{
 #!CommitTicketReference repository="" revision="55559"
 Coding Standards: Remove unused variables in `WP_Comment_Query`.

 * `$unapproved_ids` and `$unapproved_emails` in
 `WP_Comment_Query::get_comment_ids()` were added in [29965] and appear to
 never have been used.
 * `$wpdb` in `WP_Comment_Query::fill_descendants()` was replaced with
 `$this->db` in [38275], removed in [38446], and accidentally reinstated in
 [38768].

 Follow-up to [29965], [34546], [37625], [38275], [38446], [38768],
 [44546].

 Props upadalavipul, dingo_d, audrasjb, SergeyBiryukov.
 Fixes #57482.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57482#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list