[wp-trac] [WordPress Trac] #57397: Twenty Nineteen: Remove Unused function parameter and variable.
WordPress Trac
noreply at wordpress.org
Sun Mar 12 10:00:24 UTC 2023
#57397: Twenty Nineteen: Remove Unused function parameter and variable.
------------------------------+-------------------------------
Reporter: upadalavipul | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.3
Component: Bundled Theme | Version: 5.0
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses: coding-standards
------------------------------+-------------------------------
Comment (by sabernhardt):
1. The `twentynineteen_post_thumbnail_sizes_attr` filter shows the default
priority and accepted arguments `, 10, 1`. The two filters could be
consistent.
2. The `twentynineteen_nav_menu_link_attributes` DocBlock has a typo we
could fix (either here or on #57840): "Adjustments to menu attributes
''tot'' support WCAG 2.0 recommendations for flyout and dropdown menus."
3. I like that the PR uses the variable for comments navigation, but those
translations probably should be replaced anyway (on a new ticket).
Separating "Previous" and "Next" from "Comments" can result in faulty
translations.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57397#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list