[wp-trac] [WordPress Trac] #46561: Make wp_normalize_path() on Windows resolve drive letter for drive–relative paths
WordPress Trac
noreply at wordpress.org
Sun Mar 12 08:45:38 UTC 2023
#46561: Make wp_normalize_path() on Windows resolve drive letter for drive–relative
paths
--------------------------------------+------------------------------
Reporter: Rarst | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Filesystem API | Version: 3.9
Severity: minor | Resolution:
Keywords: needs-patch dev-feedback | Focuses:
--------------------------------------+------------------------------
Comment (by Rarst):
I now think making this check for a real file is too major of a backwards
compatibility break. It's simply not what the function currently does and
it's so generic, there is no way to tell what could that break in the
wild.
By the way disk checks can be very expensive for performance. Hitting disk
is much slower than memory and on Windows file exists checks are not as
heavily cached by file system as on Linux, so they can cause massive
slowdowns there, if called often. I would probably only consider
introducing an implicit disk lookup if one is functionally unavoidable.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46561#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list