[wp-trac] [WordPress Trac] #57814: Use `wp_theme_has_theme_json` in `_wp_theme_json_webfonts_handler`
WordPress Trac
noreply at wordpress.org
Fri Mar 10 23:23:11 UTC 2023
#57814: Use `wp_theme_has_theme_json` in `_wp_theme_json_webfonts_handler`
---------------------------+------------------------------
Reporter: spacedmonkey | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Script Loader | Version: 6.0
Severity: normal | Resolution:
Keywords: has-patch | Focuses: performance
---------------------------+------------------------------
Comment (by flixos90):
Replying to [comment:9 spacedmonkey]:
> @flixos90 I don't think the FE performance is the only metric we judge
things on. If this had no FE benefit, it would still be worth doing.
>
> As you can see from the above screenshots are the the posts REST API
endpoint, there is a nearly 4ms improvement.
I didn't say that it was the only metric, I said it was the most important
one. Frontend performance affects every WordPress experience a website
visitor has, except for a small fraction of headless sites. The horizontal
impact of performance in the REST API is far lower. I'm not saying it is
not important, but it is ''less'' important.
Anyway, this is a very promising enhancement when it comes to performance.
However, we shouldn't commit this without figuring out why rendering the
template sees a regression. I would love for this change to land, but we
need to take the time and figure out the one remaining issue here before
we can reasonably commit it.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57814#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list