[wp-trac] [WordPress Trac] #20027: Use get_(template|stylesheet) instead of get_option( '(template|stylesheet)' )
WordPress Trac
noreply at wordpress.org
Thu Mar 2 15:42:48 UTC 2023
#20027: Use get_(template|stylesheet) instead of get_option(
'(template|stylesheet)' )
-----------------------------------------------+-------------------------
Reporter: ocean90 | Owner: (none)
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Themes | Version:
Severity: normal | Resolution: maybelater
Keywords: has-patch early changes-requested | Focuses:
-----------------------------------------------+-------------------------
Changes (by audrasjb):
* keywords: has-patch dev-feedback => has-patch early changes-requested
* status: new => closed
* resolution: => maybelater
* milestone: Future Release =>
Comment:
As per today's old tickets triage session:
From @hellofromTonya: Given the age of this ticket and how long these
unfiltered usages have been in Core, why change some of them to filtered?
The inconsistencies will still exist in Core. So it doesn't fully solve
the problem request of reaching consistency. But it does increase the
risks of unknown issues.
From @costdev: Any change to call get_stylesheet() will run the additional
filter, so isn't this always going to be a potential BC break/regression
because we don't know what someone is hooking to the 'stylesheet' filter?
Let's close this ticket as wontfix, and eventually open a new general
ticket to handle inconsistencies in a future release.
Props @hellofromTonya, @joedolson, @SergeyBiryukov, @costdev for the
triage discussion.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/20027#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list