[wp-trac] [WordPress Trac] #58494: Reduce frequency of https check when https is already working

[WordPress Trac]

#58494: Reduce frequency of https check when https is already working
-------------------------------------------------+-------------------------
 Reporter:  adamsilverstein                      |       Owner:
                                                 |  adamsilverstein
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.4
Component:  Security                             |     Version:  5.7
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing needs-testing-info     |     Focuses:
  needs-patch                                    |  sustainability
-------------------------------------------------+-------------------------

Comment (by adamsilverstein):

 > Some details on how to test will help drive this forward.

 Hi @hareesh-pillai -
 Here are some steps to test:

 Before and after the patch:
 - Set up a site with valid SSL (also, test with invalid SSL if possible)
 - Use wp-cli to check when the next `wp_https_detection` cron job is
 scheduled. Use this command: `wp cron event list`, look for the
 `wp_https_detection` row
 - Note the 'recurrence' column, the expected default value will be `12
 hours`
 - Run the check cron event: `wp cron event run wp_https_detection`
 - Check the cron job list again (`wp cron event list`)
 - Before the patch, the `recurrence` will remain at 12 hours
 - After the patch, if the SSL is valid, the `recurrence` will change to 1
 week

 > I tried testing this patch on a site on production with https enabled,
 and it didn't work: the scheduled event never switched to weekly (checking
 with WP Crontrol).

 @audrasjb

 Did you leave the patch in place for at least 12 hours? the `recurrence`
 will only change to 1 week after the next cron check.

 > Also, the PR is still a draft, so let's move this ticket to milestone
 6.4.

 Have to stop making them drafts, I'll update that!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58494#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform