[wp-trac] [WordPress Trac] #58558: Twenty Nineteen: Separator block does not support theme colors in editor

[WordPress Trac]

#58558: Twenty Nineteen: Separator block does not support theme colors in editor
-------------------------------------------------+-------------------------
 Reporter:  nidhidhandhukiya                     |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.3
Component:  Bundled Theme                        |     Version:  6.2.2
 Severity:  minor                                |  Resolution:
 Keywords:  has-patch has-screenshots has-       |     Focuses:  css
  testing-info changes-requested                 |
-------------------------------------------------+-------------------------
Changes (by costdev):

 * keywords:  has-patch has-screenshots has-testing-info => has-patch has-
     screenshots has-testing-info changes-requested


Comment:

 Reviewing the patches:
 - [https://core.trac.wordpress.org/attachment/ticket/58558/58558.patch
 58558.patch] makes changes to `style.css` rather than `style-editor.scss`
 and building to `style-editor.css`.
 - [https://core.trac.wordpress.org/attachment/ticket/58558/58558.2.patch
 58558.2.patch] makes changes to the correct files but has some spacing
 issues with the curly braces that don't appear for me locally after using
 the theme's build script.
 - [https://github.com/WordPress/wordpress-develop/pull/4690 PR 4690] makes
 changes to `style-editor.scss`, but not `style-editor.css`. It needs a run
 of `npm i && npm run build` in the local theme directory to build `style-
 editor.css`, commit the changes and push to the PR. I've left a similar
 note on the PR.

 Adding `changes-requested`.

 As [https://github.com/WordPress/wordpress-develop/pull/4690 PR 4690] is
 the latest patch, I'll submit a test report for it below (assuming the
 `npm i && npm run build` commands were run on it and it was updated).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58558#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform