[wp-trac] [WordPress Trac] #58918: HTML API: Adjust code stying to Gutenberg's linter's preferences

[WordPress Trac]

#58918: HTML API: Adjust code stying to Gutenberg's linter's preferences
-------------------------+------------------------------
 Reporter:  dmsnell      |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  HTML API     |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------------

Comment (by dmsnell):

 > Obviously not, otherwise you wouldn't have to make this change :-)

 ha! tell that to the people implementing WPCS 😄

 > Can you perhaps elaborate on why this code needs to satisfy the
 different CS requirements from the Gutenberg repo? As far as I can tell
 this code only lives in the WordPress repo.

 This is part of a standard "backporting" process to bring updates in Core
 to Gutenberg. Because of recurring conflicts arising between people who
 work on different sides of the codebase (Gutenberg and WordPress SVN) I
 have been building code in Core first, bringing them over to Gutenberg.

 This code does live in Gutenberg and must live in Gutenberg until
 Gutenberg no longer supports versions of Core that don't have the required
 library. Even then, as long as updates are applied in Core they need to be
 backported into Gutenberg to avoid crashing or corrupting sites with the
 plugin activated.

 This should be a trivial patch; is there anything in the contents of the
 patch you object to? I don't believe it's going to be a productive place
 to address longstanding systematic issues between Gutenberg and Core 😄

 For what it's worth, I do believe that it's the goal of people working on
 the WordPress Coding Standards to harmonize the repos. Unfortunately we're
 left stranded until that happens because they've decided to reject patches
 with issues; so we go through the ritual of updating style so we aren't
 blocked 🤷‍♂️ This is the same process for updating any Core code that
 Gutenberg relies on.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58918#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform