[wp-trac] [WordPress Trac] #58896: Fix WP_List_Table magic methods for PHP 8.2 dynamic properties
WordPress Trac
noreply at wordpress.org
Tue Jul 25 23:29:38 UTC 2023
#58896: Fix WP_List_Table magic methods for PHP 8.2 dynamic properties
--------------------------------------------+-----------------------------
Reporter: antonvlasenko | Owner: hellofromTonya
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 6.4
Component: Administration | Version: 4.0
Severity: normal | Resolution:
Keywords: php82 has-patch has-unit-tests | Focuses:
--------------------------------------------+-----------------------------
Comment (by hellofromTonya):
After thinking about impacts on users and talking with @azaozz, I think
Option 1 is the right way forward.
Though the magic methods introduced a BC break, that happened 9 years ago.
Fast forward to today, plugins are (and have been) using that code. I
think the current code is the yardstick for determining if the new fix is
a BC break or not. Using that yardstick, Option 2 would be a BC break to
the current code and thus could/would impact users.\
@antonvlasenko I'll review https://github.com/WordPress/wordpress-
develop/pull/4905 tomorrow with the goal of committing it this week or
next.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/58896#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list