[wp-trac] [WordPress Trac] #58555: Backport: Duotone changes, refactor, enhancements and fixes

[WordPress Trac]

#58555: Backport: Duotone changes, refactor, enhancements and fixes
-------------------------------------------------+-------------------------
 Reporter:  onemaggie                            |       Owner:
                                                 |  isabel_brison
     Type:  task (blessed)                       |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.3
Component:  Editor                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests gutenberg-merge has-  |     Focuses:
  patch                                          |
-------------------------------------------------+-------------------------
Changes (by spacedmonkey):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 @isabel_brison As you know, once code is in core is can not be changed.
 Either it changed now and it will never get changed. I am strongly against
 the use of static in this class. My PR proves the fact it is unneeded.
 Code quality is important, as this code has be maintained. Static code
 like this, is hard to maintain as it does follow the pattern of other core
 classes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58555#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform