[wp-trac] [WordPress Trac] #58206: Replace usage of strpos with str_contains

WordPress Trac noreply at wordpress.org
Mon Jul 17 13:16:30 UTC 2023


#58206: Replace usage of strpos with str_contains
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  6.3
Component:  General                              |     Version:
 Severity:  blocker                              |  Resolution:  fixed
 Keywords:  good-first-bug 2nd-opinion add-to-   |     Focuses:  coding-
  field-guide                                    |  standards
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 In [changeset:"56245" 56245]:
 {{{
 #!CommitTicketReference repository="" revision="56245"
 Code Modernization: Use `str_contains()` in a few more places.

 `str_contains()` was introduced in PHP 8.0 to perform a case-sensitive
 check indicating if the string to search in (haystack) contains the given
 substring (needle).

 WordPress core includes a polyfill for `str_contains()` on PHP < 8.0 as of
 WordPress 5.9.

 This commit replaces `false !== strpos( ... )` with `str_contains()` in
 core files, making the code more readable and consistent, as well as
 better aligned with modern development practices.

 Follow-up to [55988], [55990], [56014], [56021], [56031], [56032],
 [56065], [56241].

 See #58206.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58206#comment:63>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list