[wp-trac] [WordPress Trac] #58703: wp-list-table: <label> is preceding <input> in the checkbox column

WordPress Trac noreply at wordpress.org
Sun Jul 16 15:31:47 UTC 2023


#58703: wp-list-table: <label> is preceding <input> in the checkbox column
-------------------------------------+----------------------------
 Reporter:  dimitris.m               |       Owner:  joedolson
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  6.3
Component:  Administration           |     Version:  trunk
 Severity:  minor                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  accessibility
-------------------------------------+----------------------------
Changes (by joedolson):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 Changing the order of the label/input means that we can no longer use the
 `+` selector in CSS. Makes me wish for a preceding element selector. The
 patch is functional, but it opens up a wider gateway to potential
 compatibility issues with plugins, since it's now selecting descendents of
 `.check-column`. Could have also done this by adding two new classes, but
 I prefer this for simplicity.

 However, I'm hesitant to make the switch this close to release candidate,
 since it does introduce new potential for compatibility issues and only
 fixes a potential false positive in testing. This may be better considered
 as a change to be made in 6.4, so that issues can be resolved early.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58703#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list