[wp-trac] [WordPress Trac] #58673: WordPress database error when installing PHPUnit tests

[WordPress Trac]

#58673: WordPress database error when installing PHPUnit tests
--------------------------------------------+---------------------------
 Reporter:  Chouby                          |       Owner:  spacedmonkey
     Type:  defect (bug)                    |      Status:  closed
 Priority:  high                            |   Milestone:  6.3
Component:  Editor                          |     Version:  trunk
 Severity:  normal                          |  Resolution:  fixed
 Keywords:  has-patch needs-testing commit  |     Focuses:  performance
--------------------------------------------+---------------------------
Changes (by spacedmonkey):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"56226" 56226]:
 {{{
 #!CommitTicketReference repository="" revision="56226"
 Editor: Lazily load Duotone settings only when needed.

 Introduced in [56101] the `WP_Duotone` class, hooks into the `wp_loaded`
 action to load duotone style data from global styles. Hooking in early in
 the bootstrap process caused a number of problems. This hook, triggered an
 error on installing, as this lookup for global styles, would result in a
 global post trying to be created, even before the table existed.
 Additionally, this implementation caused a severe performance regression,
 as duotone styling data was loaded unnecessarily for requests that did not
 require such data, such as REST API calls or actions within the wp-admin
 interface.

 In this change, refactor the `WP_Duotone` to lazily load the global styles
 and theme.json data, only when a block that supports duotone is
 encountered. The method `render_duotone_support` was change to take a
 third parameter to reuse the existing `WP_Block_Type` object passed to the
 filter, to save it being looked up again. The code has also got improved
 type checking and the use of the util function  `block_has_support`.
 Furthermore, the code's readability has been improved, along with
 enhancements to the documentation blocks.

 Props Chouby, spacedmonkey, SergeyBiryukov, swissspidy, costdev,
 joemcgill, flixos90, mukesh27, nazmul111, ajlende, isabel_brison.
 Fixes #58673.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58673#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform