[wp-trac] [WordPress Trac] #56228: Add main H1 heading in the site-editor page

WordPress Trac noreply at wordpress.org
Thu Jul 6 13:33:22 UTC 2023


#56228: Add main H1 heading in the site-editor page
---------------------------------------+----------------------------
 Reporter:  afercia                    |       Owner:  joedolson
     Type:  defect (bug)               |      Status:  reopened
 Priority:  normal                     |   Milestone:  6.3
Component:  Editor                     |     Version:  trunk
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  accessibility
---------------------------------------+----------------------------
Changes (by afercia):

 * keywords:  has-screenshots needs-patch => has-screenshots has-patch


Comment:

 [attachment:"56228.4.diff"] needs to be tested together with the changes
 from https://github.com/WordPress/gutenberg/pull/52376 in the Gutenberg
 plugin (those changes will need to be ported to core).

 - Removes a left padding from the Site editor and Post editor page, as
 it's no longer needed.
 - Removes the `notice-alt` class from the no-js notices as the page
 background color is now the default light grey. Instead, the `notice-alt`
 style is only meant to be used on pages with a white background.

 To test:
 - Disable JS support in your browser.
 - Go to the Site editor page, to the Post editor page, and to the Add new
 theme page `/wp-admin/theme-install.php`.
 - Observe they look the same:
   - Visible heading at the top of the page.
   - An error notice below the heading.
   - Check the page footer is visible.

 See screenshots below.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56228#comment:43>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list