[wp-trac] [WordPress Trac] #56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a public function

WordPress Trac noreply at wordpress.org
Fri Jan 20 08:43:18 UTC 2023


#56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a
public function
-------------------------------------------------+-------------------------
 Reporter:  oandregal                            |       Owner:
                                                 |  hellofromTonya
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.2
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback gutenberg-merge has-    |     Focuses:
  patch has-unit-tests has-testing-info          |  performance
-------------------------------------------------+-------------------------

Comment (by oandregal):

 > I will try getting numbers for the static variable cache on my analysis
 as well, since that looks quite promising in yours.

 Yeah, though, I wouldn't recommend going back to that point. The fact that
 it leaks into the API (parameter in the function to clean the cache) is
 not great. The performance improvement is negligible compared to other
 much bigger impact we can have with changes in other areas (upcoming PRs,
 etc.).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56975#comment:69>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list