[wp-trac] [WordPress Trac] #56790: PHP 8.x: various compatibility fixes for WordPress 6.2
WordPress Trac
noreply at wordpress.org
Fri Jan 20 01:34:55 UTC 2023
#56790: PHP 8.x: various compatibility fixes for WordPress 6.2
-------------------------------------------------+-------------------------
Reporter: SergeyBiryukov | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 6.2
Component: General | Version:
Severity: normal | Resolution:
Keywords: php8 php81 php82 has-patch has- | Focuses: coding-
unit-tests | standards
-------------------------------------------------+-------------------------
Comment (by SergeyBiryukov):
In [changeset:"55105" 55105]:
{{{
#!CommitTicketReference repository="" revision="55105"
Code Modernization: Use correct property in `IXR_Message::tag_open()`.
The `IXR_Message` class declares a property `_currentTag`, which is never
assigned or used. It does assign to `currentTag` instead, which outside of
that one assignment is never used either.
Since there are various other underscore-prefixed properties declared on
the class, including one named `_currentTagContents` which is used in
several places, it appears that the declared property is correct and the
assignment is a typo.
This commit resolves a notice on PHP 8.2:
{{{
Deprecated: Creation of dynamic property IXR_Message::$currentTag is
deprecated
}}}
Follow-up to [1346].
Props bjorsch, kraftbj, jrf, mukesh27, SergeyBiryukov.
See #56790.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56790#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list