[wp-trac] [WordPress Trac] #56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a public function
WordPress Trac
noreply at wordpress.org
Thu Jan 19 14:33:19 UTC 2023
#56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a
public function
-------------------------------------------------+-------------------------
Reporter: oandregal | Owner:
| hellofromTonya
Type: enhancement | Status: reopened
Priority: normal | Milestone: 6.2
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: dev-feedback gutenberg-merge has- | Focuses:
patch has-unit-tests has-testing-info | performance
-------------------------------------------------+-------------------------
Comment (by Otto42):
Call me crazy, but.. what does this entire change actually do?
Because as near I can see, the only purpose for the
wp_theme_has_theme_json function, is to add the use of caching around a
couple of file_exists calls. And that's fine, fair enough.
But then you go to the trouble of ensuring that the cache is non-
persistent and cleared a fair amount. And now we're talking about stubbing
out the cache functions, ensuring that this won't be cached, on every wp-
admin screen that uses load-styles (which is all of them).
So, one has to wonder, why all the effort to do the caching in the first
place? What am I missing?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56975#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list