[wp-trac] [WordPress Trac] #57293: Twenty Twenty-One: Incorrect Mastodon domain (mastodon.com) for Social Icon in Footer Menu
WordPress Trac
noreply at wordpress.org
Thu Jan 12 00:47:05 UTC 2023
#57293: Twenty Twenty-One: Incorrect Mastodon domain (mastodon.com) for Social Icon
in Footer Menu
---------------------------+---------------------
Reporter: triumvirate | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.2
Component: Bundled Theme | Version: 5.6
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
---------------------------+---------------------
Comment (by peterwilsoncc):
Thanks for the pull request!
I've been thinking about this and @sabernhardt's earlier suggestion of ten
is good, otherwise the regex generated by the domains is going to be
noticable.
It might be worth setting up a plugin with more known instances using the
code above for the filter.
You're right, there are no unit tests for this functionality so I wouldn't
worry too much about adding anything additional just yet.
One last thing, are you able to link your GitHub account you're
wordpress.org profile, you can
[https://profiles.wordpress.org/me/profile/edit/group/1/ link the account
on this screen] -- linking the accounts will ensure that your
contributions are counted correctly.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57293#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list