[wp-trac] [WordPress Trac] #3534: Hide password in setup-config.php
WordPress Trac
noreply at wordpress.org
Thu Jan 5 04:25:03 UTC 2023
#3534: Hide password in setup-config.php
-------------------------------------------------+-------------------------
Reporter: xmarcos | Owner: rob1n
Type: enhancement | Status: reopened
Priority: low | Milestone: 6.2
Component: Upgrade/Install | Version: 2.1
Severity: normal | Resolution:
Keywords: has-patch needs-testing has- | Focuses:
testing-info has-screenshots | accessibility
-------------------------------------------------+-------------------------
Comment (by bgoewert):
Thanks for testing this on macOS @ironprogrammer!
It took me some time to figure out how RTL was working in WP and to
research your ⚠️ results.
> ⚠️ In Chrome and Firefox on macOS, the toggle button's :focus outline is
activated when clicked, which is visually different from Safari. See
Figure 4.
Safari does this on purpose. See
https://bugs.webkit.org/show_bug.cgi?id=22261
If you try this on other buttons around WP, it behaves in the same manner.
Note though I only tested the login page.
Login page on Safari 16: https://imgur.com/eL35rzR.mp4
Compared to Chrome 108 : https://imgur.com/9npcBLU.mp4
Do we remove the border for all the other browsers so that it visually
aligns with Safari?
> ⚠️ In RTL languages, the "eye" toggle shifts to the left of the field,
separate from the 1Password toggle (compare this to RTL results in
https://core.trac.wordpress.org/ticket/9883#comment:44 where the toggles
remain grouped). See Figure 5.
This is also default behavior around WP. Note this image of the login
page, the password toggle is on the left and password manager on the
right.
[[Image(https://i.imgur.com/yWQXeug.png)]]
I've tried to test this by changing the primary language on Chrome. And it
did change the language for the extension, but not the position of the
icons ([https://i.imgur.com/DBfL0cf.png image proof]). Testing on an OS
with a RTL language, rather than simply changing the WP language, may
change the behavior of the browser as well as password manager extensions
and yield a different result (but not likely).
Is the plan to change all the other password visibility toggles to align
to the right so these icons are grouped?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/3534#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list