[wp-trac] [WordPress Trac] #57648: Performance regression in `wp_enqueue_global_styles()` for classic themes
WordPress Trac
noreply at wordpress.org
Tue Feb 21 10:18:34 UTC 2023
#57648: Performance regression in `wp_enqueue_global_styles()` for classic themes
--------------------------+--------------------------
Reporter: flixos90 | Owner: (none)
Type: defect (bug) | Status: new
Priority: high | Milestone: 6.2
Component: Editor | Version: trunk
Severity: normal | Resolution:
Keywords: | Focuses: performance
--------------------------+--------------------------
Comment (by oandregal):
Thanks for investigating and sharing your observations, Felix.
I wanted to add a small note: the transient behavior was a bug. Users
didn't see the changes they did in the site editor until 1 minute later
because the transient wasn't invalidated properly. And, in some setups,
the transient wasn't even flushed at all, causing issues with layout in
6.1 as per https://github.com/WordPress/gutenberg/issues/45713 It's good
that it was removed.
All in all, the overall performance for 6.2 has been improved for all
themes, so I agree we should close this ticket and focus on other things
(investigate how to switch these caches to be persistent, fix more
performance bottlenecks for all themes, etc.).
As a side note, we can probably see a similar effect in the
`wp_get_global_styles_svg_filters` function, that was also updated from a
1-minute transient to a non-persistent object cache in
https://github.com/WordPress/wordpress-develop/pull/3926
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57648#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list