[wp-trac] [WordPress Trac] #57690: The get_delete_post_link function uses the deprecated parameter
WordPress Trac
noreply at wordpress.org
Sat Feb 11 00:42:15 UTC 2023
#57690: The get_delete_post_link function uses the deprecated parameter
------------------------------------+-------------------------------
Reporter: krunal265 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.2
Component: Options, Meta APIs | Version:
Severity: normal | Resolution:
Keywords: has-patch commit php81 | Focuses: coding-standards
------------------------------------+-------------------------------
Changes (by jrf):
* keywords: has-patch => has-patch commit php81
* milestone: Awaiting Review => 6.2
Comment:
@krunal265 Thanks for this ticket and the patch. I've reviewed the issue
and the patch and I concur this is the correct fix.
Two questions:
1. Would it be possible to add a unit test for the function to safeguard
the fix against regressions ?
2. Might it be a good idea to do a code search of the whole WP Core code
base for all uses of the `get_delete_post_link()` function to review and
verify that this issue doesn't exist in more places ?
Note for committers: the patch as-is can go in. Potential results from
follow-up actions resulting from my questions can be handled separately
(and tests can still go in during beta).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57690#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list