[wp-trac] [WordPress Trac] #16502: Quick Edit contents should only be rendered if quick edit button in actions after filtering
WordPress Trac
noreply at wordpress.org
Tue Feb 7 22:50:16 UTC 2023
#16502: Quick Edit contents should only be rendered if quick edit button in actions
after filtering
-------------------------------------------------+-------------------------
Reporter: wyrfel | Owner: chriscct7
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 6.3
Component: Quick/Bulk Edit | Version: 3.0.4
Severity: normal | Resolution:
Keywords: has-testing-info dev-feedback has- | Focuses:
unit-tests 2nd-opinion |
-------------------------------------------------+-------------------------
Changes (by azaozz):
* keywords:
has-patch has-testing-info needs-dev-note dev-feedback has-unit-tests
commit
=> has-testing-info dev-feedback has-unit-tests 2nd-opinion
Comment:
Having some doubts about this patch. It effectively disables one of the
WordPress features: Quick Edit. As far as I know this feature is not used
very often, but is quite helpful for Editors on sites with many
users/authors.
The disabling is done indirectly, by "piggybacking" on other/existing
methods. Don't think this is a good way to disable a feature. A better way
would be to have a filter where extenders will be able to disable it
directly.
In addition the current code may introduce bugs/regressions in plugins
that replace the "Quick Edit" action link with another method of showing
the UI, or reuse the quick edit data in some way.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/16502#comment:50>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list