[wp-trac] [WordPress Trac] #56689: Use WP_Query in get_page_by_path

[WordPress Trac]

#56689: Use WP_Query in get_page_by_path
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:
                                                 |  spacedmonkey
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Query                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing has-patch has-unit-    |     Focuses:
  tests has-testing-info 2nd-opinion             |  performance
-------------------------------------------------+-------------------------
Changes (by peterwilsoncc):

 * milestone:  6.2 => Future Release


Comment:

 As noted on the PR, I am not keen on the forked approach of sometimes
 using `WP_Query`, sometimes using an SQL statement.

 The effect is that any changes to this function will need to be made
 twice, which can easily be missed by future contributor (possibly those
 following this ticket).

 Instead of rushing a fix for the beta, I think it best to come back to
 this and see how it can be improved without the forked code.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56689#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform