[wp-trac] [WordPress Trac] #57557: Switch copy_dir() with move_dir() in WP_Upgrader::install_package

[WordPress Trac]

#57557: Switch copy_dir() with move_dir() in WP_Upgrader::install_package
-----------------------------+-----------------------------
 Reporter:  afragen          |       Owner:  SergeyBiryukov
     Type:  enhancement      |      Status:  reopened
 Priority:  normal           |   Milestone:  6.2
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  performance
-----------------------------+-----------------------------

Comment (by swissspidy):

 It seems like this change broke translation installs/updates. It's no
 longer possible to have multiple languages installed.

 To reproduce on WP trunk via wp-admin:

 1. Go to Settings -> General
 2. Under Site Language, choose a new language to install, like Français,
 and save the settings.
 3. The page will reload and the translation will be installed in the
 background.
 4. Notice how the dropdown now says Français is installed.
 5. Now, select Italiano from the dropdown and save the settings again.
 6. The page will reload and the translation will be installed in the
 background.
 7. Notice how the dropdown now says Italiano is installed, **but Français
 is not**.

 To reproduce with WP-CLI

 1. `npm run env:start`
 2. `npm run env:cli "wp language core install de_CH de_DE es_ES fr_FR
 it_IT"`
 3. Notice how the WP-CLI output says all languages have been successfully
 installed. However, only the last language in the list (it_IT) is actually
 kept in the filesystem. The previous files have all been wiped.
 4. You can verify this with `npm run env:cli "wp language core list
 --status=installed"` or by going to Settings -> General and checking the
 language dropdown where it says only en_US and it_IT are installed.
 5. Likewise, if I run `npm run env:cli "wp language core install de_CH"`,
 it_IT is wiped and only de_CH remains.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57557#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform