[wp-trac] [WordPress Trac] #57557: Switch copy_dir() with move_dir() in WP_Upgrader::install_package

[WordPress Trac]

#57557: Switch copy_dir() with move_dir() in WP_Upgrader::install_package
-----------------------------+-----------------------------
 Reporter:  afragen          |       Owner:  SergeyBiryukov
     Type:  enhancement      |      Status:  accepted
 Priority:  high             |   Milestone:  6.2
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  performance
-----------------------------+-----------------------------

Comment (by costdev):

 > As this runs automatically, wondering if this case should be excluded
 for now, just to be on the safe side.

 My only concern is that if we exclude language packs during the Beta/RC
 periods, we may have a difficult time getting a tester base for this. On
 the other hand, we can ask testers during Beta to test plugin, theme and
 language pack upgrades, and to report any issues they encounter with any
 of the upgrade types. That ''should'' expose any issues and give us the
 data we need.

 Do we have any indication that language pack upgrades would encounter an
 issue? Despite happening automatically, we know they don't contain
 executable code, so a Fatal Error, etc shouldn't occur, OPcache
 invalidation won't be necessary for those, and the "move" portion of
 `move_dir()` is solid. Are there any other ways it could fail?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/57557#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform