[wp-trac] [WordPress Trac] #56754: Use consistent, coding standard compliant naming for category ID variables
WordPress Trac
noreply at wordpress.org
Thu Feb 2 03:49:17 UTC 2023
#56754: Use consistent, coding standard compliant naming for category ID variables
--------------------------+-------------------------------
Reporter: hilayt24 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.2
Component: General | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: coding-standards
--------------------------+-------------------------------
Comment (by costdev):
Hi @robinwpdeveloper, thanks for the ping!
I agree that
[https://core.trac.wordpress.org/attachment/ticket/56754/%2356754.patch
#56754.patch] is more straightforward, as the other patch contains a
condition and unrelated inline comments.
Thanks for the PR which verified no tests were broken by the changes!
I've left [https://github.com/WordPress/wordpress-
develop/pull/3961#discussion_r1093970319 a review] noting that we can't
change function parameter casing due to named parameters in PHP 8, which
are case-sensitive.
Can you update the PR to remove the changes in `src/wp-
includes/deprecated.php` and `src/wp-includes/taxonomy.php`?
Other than that, I think the PR is good to go.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56754#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list