[wp-trac] [WordPress Trac] #60074: Add New Media File > The ''dismiss button ''not showing any response when uploading the unsupported (.jfif) file
WordPress Trac
noreply at wordpress.org
Fri Dec 15 16:18:17 UTC 2023
#60074: Add New Media File > The ''dismiss button ''not showing any response when
uploading the unsupported (.jfif) file
--------------------------+------------------------------
Reporter: vivekawsm | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Media | Version: 6.4.2
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
--------------------------+------------------------------
Comment (by adamsilverstein):
Although the current patch fixes the issue, the button is being changed to
a link and I found that it was previously changed from a link to a button
for accessibility reasons, see https://github.com/WordPress/wordpress-
develop/commit/ef84e589d2bc25952bee31940a5a11c3fa75f599
For this reason, I don't think we should make the fix as proposed, can we
find a different fix that maintains the semantic button element?
I agree we should remove the inline JavaScript anyway I believe it is
being stripped already. Can we expand the existing JS handler to correctly
handle the button click?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/60074#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list