[wp-trac] [WordPress Trac] #60045: Change to add_new label displays wrong label for old post types

[WordPress Trac]

#60045: Change to add_new label displays wrong label for old post types
----------------------------+------------------------------
 Reporter:  smerriman       |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  6.4
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+------------------------------
Description changed by SergeyBiryukov:

Old description:

> In https://core.trac.wordpress.org/ticket/47125, the label for adding a
> new item in the menu changed its default value from Add New to Add New
> Post, with developers advised to change their code to match when creating
> custom content types.
>
> To me this was a mistake; an appropriate label already existed with that
> wording: the add_new_item label.
>
> If it was desired to change what displayed in the menu, the right fixing
> was to use display add_new_item, rather than changing the entire meaning
> of add_new.
>
> I have always registered custom post types by setting add_new_item to
> 'Add New MyPostType', and leaving add_new out of the array entirely,
> since there was never a need to override the wording of 'Add New'.
>
> Now, all of my post types for all clients over many years are displaying
> 'Add New Post'.
>
> Can this change please be reverted, and replaced by displaying
> add_new_item when you wanted to display the item name, as it was always
> intended to be used?

New description:

 In #47125, the label for adding a new item in the menu changed its default
 value from Add New to Add New Post, with developers advised to change
 their code to match when creating custom content types.

 To me this was a mistake; an appropriate label already existed with that
 wording: the add_new_item label.

 If it was desired to change what displayed in the menu, the right fixing
 was to use display add_new_item, rather than changing the entire meaning
 of add_new.

 I have always registered custom post types by setting add_new_item to 'Add
 New MyPostType', and leaving add_new out of the array entirely, since
 there was never a need to override the wording of 'Add New'.

 Now, all of my post types for all clients over many years are displaying
 'Add New Post'.

 Can this change please be reverted, and replaced by displaying
 add_new_item when you wanted to display the item name, as it was always
 intended to be used?

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60045#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform