[wp-trac] [WordPress Trac] #58361: Passing 'none' as 'menu_icon' to 'register_post_type' is not working correctly

[WordPress Trac]

#58361: Passing 'none' as 'menu_icon' to 'register_post_type' is not working
correctly
--------------------------------------------+-----------------------------
 Reporter:  andrewleap                      |       Owner:  SergeyBiryukov
     Type:  defect (bug)                    |      Status:  closed
 Priority:  normal                          |   Milestone:  6.5
Component:  Administration                  |     Version:  3.0
 Severity:  minor                           |  Resolution:  fixed
 Keywords:  has-patch needs-testing commit  |     Focuses:
--------------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"57159" 57159]:
 {{{
 #!CommitTicketReference repository="" revision="57159"
 Administration: Don't unnecessarily escape `none` or `div` in the admin
 menu.

 This matches a similar conditional in `wp-admin/menu-header.php`, where
 these values are handled as special cases and don't output the default
 menu image so that an icon could be added to `div.wp-menu-image` as CSS
 background.

 Follow-up to [9578], [21877], [26664].

 Props andrewleap, ironprogrammer, azaozz.
 Fixes #58361.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58361#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform