[wp-trac] [WordPress Trac] #59935: Site editor: logo

[WordPress Trac]

#59935: Site editor: logo
-------------------------------------------------+-------------------------
 Reporter:  priethor                             |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.4.2
Component:  Editor                               |     Version:  6.4
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-testing-info has-unit-tests      |     Focuses:  rest-api
  has-patch commit fixed-major dev-reviewed      |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"57154" 57154]:
 {{{
 #!CommitTicketReference repository="" revision="57154"
 REST API: Restore site logo and icon in index.

 Restores setting the site's logo, icon, and wp-admin's back button image
 (which defaults to W).

 Prior to [56566], the site logo and icon were unconditionally added to the
 index. [56566] changed this by conditionally adding them if either the
 `_links` or `_embedded` fields were included. However, these fields are
 not included when using the Site Logo block, as it uses the `site_logo`,
 `site_icon`, and `site_icon_url` fields instead.

 This changeset restores the functionality by checking specifically for the
 `site_*` fields when neither of the `_links` or `_embedded` fields are
 present.

 Follow up to [56566].

 Reviewed by jorbin.
 Merges [57147] to the 6.4 branch.

 Props antonvlasenko, hellofromTonya, ironprogrammer, priethor, wildworks.
 Fixes #59935.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59935#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform