[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0

WordPress Trac noreply at wordpress.org
Wed Apr 12 16:27:05 UTC 2023


#54504: Update Requests library to version 2.0.0
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  closed
 Priority:  normal                               |   Milestone:  6.2
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  php80 php81 has-patch has-unit-      |     Focuses:
  tests early early-like-actually-early commit   |
  add-to-field-guide                             |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:133 drzraf]:
 > `Deprecated: Return type of Requests_Cookie_Jar::offsetExists($key)
 should either be compatible with ArrayAccess::offsetExists(mixed $offset):
 bool, or the #[\ReturnTypeWillChange] attribute should be used to
 temporarily suppress the notice in /wp/wp-includes/Requests/Cookie/Jar.php
 on line 63`

 Hmm, that file no longer exists at that path in 6.2, it was moved to the
 `wp-includes/Requests/src/Cookie/` directory, and [source:tags/6.2/src/wp-
 includes/Requests/src/Cookie/Jar.php?marks=63#L55 line 63] no longer has
 any code in it.

 Might be a good idea to confirm that the site did in fact successfully
 update to 6.2, e.g. by doing a full file comparison.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:134>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list