[wp-trac] [WordPress Trac] #58064: In the comment_time function, the call to the get_comment_time function is incorrect.

WordPress Trac noreply at wordpress.org
Sat Apr 8 09:07:33 UTC 2023


#58064: In the comment_time function, the call to the get_comment_time function is
incorrect.
-------------------------------------------------+-------------------------
 Reporter:  tmatsuur                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.2.1
Component:  Comments                             |     Version:  6.2
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests fixed-      |     Focuses:
  major                                          |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"55634" 55634]:
 {{{
 #!CommitTicketReference repository="" revision="55634"
 Comments: Add missing arguments for `get_comment_time()` in
 `comment_time()`.

 In a recent change, `comment_time()` was updated to accept a `$comment_id`
 parameter for consistency with `comment_date()`, following a similar
 change for `get_comment_time()`.

 However, the new parameter was not correctly passed to
 `get_comment_time()` inside the function. It should be passed as the
 fourth parameter after `$format`, `$gmt` and `$translate`, not the second.

 This commit adds the missing arguments and a few unit tests to confirm the
 correct behavior.

 Follow-up to [55284], [55287], [55308].

 Props costdev, tmatsuur, ugyensupport, johnbillion.
 Merges [55632] to the 6.2 branch.
 Fixes #58064.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58064#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list