[wp-trac] [WordPress Trac] #56692: Update GetID3 to version 1.9.22
WordPress Trac
noreply at wordpress.org
Fri Sep 30 17:44:58 UTC 2022
#56692: Update GetID3 to version 1.9.22
--------------------------------+------------------------
Reporter: jrf | Owner: desrosj
Type: task (blessed) | Status: reviewing
Priority: normal | Milestone: 6.1
Component: External Libraries | Version: trunk
Severity: normal | Resolution:
Keywords: php81 has-patch | Focuses:
--------------------------------+------------------------
Comment (by desrosj):
I've created a PR to make it easier to see which changes will affect Core
since only a subset of files are included. Everything looks relatively
safe to me as well.
The only thing that seemed a bit weird was the
[https://github.com/WordPress/wordpress-develop/pull/3383/files#diff-
394278f805fd44b32ad348b5cf65f951aefba321db9c0bb997c7a71f21038b2bL2067-R2067
addition of error suppression] with `@` in `module.tag.id3v2.php`. There
are other instances in the library where `@` is used in a similar fashion.
I'm guessing this is just because the library currently supporting PHP
5.0.5 and up for versions 1.8.x and up.
@jrf could you give my PR a sanity check before I commit?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56692#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list